Re: r252853 - libclang: add clang_Cursor_getCXXManglings

2015-11-18 Thread Saleem Abdulrasool via cfe-commits
On Tue, Nov 17, 2015 at 5:07 PM, Reid Kleckner wrote: > This introduced a memory leak, which I'm testing a patch for. > Oops, thanks. > Aside from that, did you get Doug to review this? We probably want to be > really careful about changing libclang's C API, so you should be more > cautious he

Re: r252853 - libclang: add clang_Cursor_getCXXManglings

2015-11-17 Thread Reid Kleckner via cfe-commits
This introduced a memory leak, which I'm testing a patch for. Aside from that, did you get Doug to review this? We probably want to be really careful about changing libclang's C API, so you should be more cautious here than you would be normally. On Wed, Nov 11, 2015 at 7:57 PM, Saleem Abdulrasoo