Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

2015-10-05 Thread David Blaikie via cfe-commits
On Mon, Oct 5, 2015 at 11:37 AM, David Blaikie wrote: > > > On Mon, Oct 5, 2015 at 8:55 AM, Adrian Prantl wrote: > >> >> On Oct 2, 2015, at 3:24 PM, David Blaikie wrote: >> >> >> >> On Fri, Oct 2, 2015 at 3:21 PM, Adrian Prantl wrote: >> >>> >>> On Oct 2, 2015, at 3:01 PM, David Blaikie wrote

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

2015-10-05 Thread David Blaikie via cfe-commits
On Mon, Oct 5, 2015 at 8:55 AM, Adrian Prantl wrote: > > On Oct 2, 2015, at 3:24 PM, David Blaikie wrote: > > > > On Fri, Oct 2, 2015 at 3:21 PM, Adrian Prantl wrote: > >> >> On Oct 2, 2015, at 3:01 PM, David Blaikie wrote: >> >> >> >> On Fri, Oct 2, 2015 at 3:00 PM, Adrian Prantl wrote: >> >

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

2015-10-05 Thread Adrian Prantl via cfe-commits
> On Oct 2, 2015, at 3:24 PM, David Blaikie wrote: > > > > On Fri, Oct 2, 2015 at 3:21 PM, Adrian Prantl > wrote: > >> On Oct 2, 2015, at 3:01 PM, David Blaikie > > wrote: >> >> >> >> On Fri, Oct 2, 2015 at 3:00 PM, Adrian Prantl >

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

2015-10-02 Thread David Blaikie via cfe-commits
On Fri, Oct 2, 2015 at 3:21 PM, Adrian Prantl wrote: > > On Oct 2, 2015, at 3:01 PM, David Blaikie wrote: > > > > On Fri, Oct 2, 2015 at 3:00 PM, Adrian Prantl wrote: > >> >> On Oct 2, 2015, at 2:58 PM, David Blaikie wrote: >> >> >> >> On Fri, Oct 2, 2015 at 2:40 PM, Adrian Prantl wrote: >> >

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

2015-10-02 Thread Adrian Prantl via cfe-commits
> On Oct 2, 2015, at 3:01 PM, David Blaikie wrote: > > > > On Fri, Oct 2, 2015 at 3:00 PM, Adrian Prantl > wrote: > >> On Oct 2, 2015, at 2:58 PM, David Blaikie > > wrote: >> >> >> >> On Fri, Oct 2, 2015 at 2:40 PM, Adrian Prantl >

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

2015-10-02 Thread David Blaikie via cfe-commits
On Fri, Oct 2, 2015 at 3:00 PM, Adrian Prantl wrote: > > On Oct 2, 2015, at 2:58 PM, David Blaikie wrote: > > > > On Fri, Oct 2, 2015 at 2:40 PM, Adrian Prantl wrote: > >> >> On Oct 2, 2015, at 2:18 PM, David Blaikie wrote: >> >> This seems a little curious, so you'll have code like this: >> >

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

2015-10-02 Thread Adrian Prantl via cfe-commits
> On Oct 2, 2015, at 2:58 PM, David Blaikie wrote: > > > > On Fri, Oct 2, 2015 at 2:40 PM, Adrian Prantl > wrote: > >> On Oct 2, 2015, at 2:18 PM, David Blaikie > > wrote: >> >> This seems a little curious, so you'll have code like this:

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

2015-10-02 Thread David Blaikie via cfe-commits
On Fri, Oct 2, 2015 at 2:40 PM, Adrian Prantl wrote: > > On Oct 2, 2015, at 2:18 PM, David Blaikie wrote: > > This seems a little curious, so you'll have code like this: > > decl foo > module > def bar >member foo pointer (references the declaration of foo outside the > module, i

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

2015-10-02 Thread Adrian Prantl via cfe-commits
> On Oct 2, 2015, at 2:18 PM, David Blaikie wrote: > > This seems a little curious, so you'll have code like this: > > decl foo > module > def bar >member foo pointer (references the declaration of foo outside the > module, in the CU?) > Right. > Why is that preferable to DW

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

2015-10-02 Thread David Blaikie via cfe-commits
This seems a little curious, so you'll have code like this: decl foo module def bar member foo pointer (references the declaration of foo outside the module, in the CU?) Why is that preferable to DWARF that looks more like the AST where the declaration of foo appears in the first m