Re: r246027 - Convert a bunch of loops to ranged-for and clean up accordingly.

2015-08-27 Thread Eric Christopher via cfe-commits
On Thu, Aug 27, 2015 at 1:29 PM Eric Christopher wrote: > >> > -assert(Features[i][0] == '+' && "Invalid target feature!"); >> > +assert(Feature[0] == '+' && "Invalid target feature!"); >> >> This assert is kind of pointless now, since we'll have continued in that >> case and the followin

Re: r246027 - Convert a bunch of loops to ranged-for and clean up accordingly.

2015-08-27 Thread Eric Christopher via cfe-commits
> > > > -assert(Features[i][0] == '+' && "Invalid target feature!"); > > +assert(Feature[0] == '+' && "Invalid target feature!"); > > This assert is kind of pointless now, since we'll have continued in that > case and the following code will DTRT anyway. > > Was fairly pointless to begin wi

Re: r246027 - Convert a bunch of loops to ranged-for and clean up accordingly.

2015-08-27 Thread Justin Bogner via cfe-commits
Eric Christopher via cfe-commits writes: > Author: echristo > Date: Wed Aug 26 03:21:55 2015 > New Revision: 246027 > > URL: http://llvm.org/viewvc/llvm-project?rev=246027&view=rev > Log: > Convert a bunch of loops to ranged-for and clean up accordingly. > > Modified: > cfe/trunk/lib/Basic/Tar