Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

2015-08-18 Thread Hans Wennborg via cfe-commits
Awesome, thanks! On Tue, Aug 18, 2015 at 4:27 PM, Reid Kleckner wrote: > I merged both of them and tweaked the test case to make it work. > > On Tue, Aug 18, 2015 at 2:55 PM, Hans Wennborg wrote: >> >> On Tue, Aug 11, 2015 at 9:40 AM, Hans Wennborg wrote: >> > On Mon, Aug 10, 2015 at 12:39 PM,

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

2015-08-18 Thread Reid Kleckner via cfe-commits
I merged both of them and tweaked the test case to make it work. On Tue, Aug 18, 2015 at 2:55 PM, Hans Wennborg wrote: > On Tue, Aug 11, 2015 at 9:40 AM, Hans Wennborg wrote: > > On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits > > wrote: > >> Author: rnk > >> Date: Mon Aug 10 1

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

2015-08-18 Thread Hans Wennborg via cfe-commits
On Tue, Aug 11, 2015 at 9:40 AM, Hans Wennborg wrote: > On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits > wrote: >> Author: rnk >> Date: Mon Aug 10 14:39:01 2015 >> New Revision: 244488 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=244488&view=rev >> Log: >> [dllimport] A non

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

2015-08-11 Thread Richard Smith via cfe-commits
On Aug 11, 2015 9:45 AM, "Reid Kleckner" wrote: > > On Mon, Aug 10, 2015 at 6:40 PM, Richard Smith wrote: >> >> On Mon, Aug 10, 2015 at 5:43 PM, Reid Kleckner wrote: >>> >>> On Mon, Aug 10, 2015 at 5:00 PM, Richard Smith wrote: On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-c

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

2015-08-11 Thread Reid Kleckner via cfe-commits
Yeah, let's do that. On Tue, Aug 11, 2015 at 9:40 AM, Hans Wennborg wrote: > On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits > wrote: > > Author: rnk > > Date: Mon Aug 10 14:39:01 2015 > > New Revision: 244488 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=244488&view=rev

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

2015-08-11 Thread Reid Kleckner via cfe-commits
On Mon, Aug 10, 2015 at 6:40 PM, Richard Smith wrote: > On Mon, Aug 10, 2015 at 5:43 PM, Reid Kleckner wrote: > >> On Mon, Aug 10, 2015 at 5:00 PM, Richard Smith >> wrote: >> >>> On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: +

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

2015-08-11 Thread Hans Wennborg via cfe-commits
On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits wrote: > Author: rnk > Date: Mon Aug 10 14:39:01 2015 > New Revision: 244488 > > URL: http://llvm.org/viewvc/llvm-project?rev=244488&view=rev > Log: > [dllimport] A non-imported class with an imported key can't have a key > > Summary:

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

2015-08-10 Thread Richard Smith via cfe-commits
On Mon, Aug 10, 2015 at 5:43 PM, Reid Kleckner wrote: > On Mon, Aug 10, 2015 at 5:00 PM, Richard Smith > wrote: > >> On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: rnk >>> Date: Mon Aug 10 14:39:01 2015 >>> New Revision: 244

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

2015-08-10 Thread Reid Kleckner via cfe-commits
On Mon, Aug 10, 2015 at 5:00 PM, Richard Smith wrote: > On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rnk >> Date: Mon Aug 10 14:39:01 2015 >> New Revision: 244488 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=244488&view=

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

2015-08-10 Thread Richard Smith via cfe-commits
On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Mon Aug 10 14:39:01 2015 > New Revision: 244488 > > URL: http://llvm.org/viewvc/llvm-project?rev=244488&view=rev > Log: > [dllimport] A non-imported class with an imported key