Re: r244193 - [ObjC] Circular containers: add support of subclasses

2015-08-14 Thread Hans Wennborg via cfe-commits
Thanks! r245116. On Fri, Aug 14, 2015 at 3:30 PM, Richard Smith wrote: > Sorry for the delay, this LGTM for branch. > > > On Wed, Aug 12, 2015 at 1:09 AM, AlexDenisov <1101.deb...@gmail.com> wrote: >> >> Ping >> -- >> AlexDenisov >> Software Engineer, http://lowlevelbits.org >> >> > On 06 Aug 201

Re: r244193 - [ObjC] Circular containers: add support of subclasses

2015-08-14 Thread Richard Smith via cfe-commits
Sorry for the delay, this LGTM for branch. On Wed, Aug 12, 2015 at 1:09 AM, AlexDenisov <1101.deb...@gmail.com> wrote: > Ping > -- > AlexDenisov > Software Engineer, http://lowlevelbits.org > > > On 06 Aug 2015, at 18:15, Hans Wennborg wrote: > > > > Hi Alex, > > > > What crash is that? I don't

Re: r244193 - [ObjC] Circular containers: add support of subclasses

2015-08-12 Thread AlexDenisov via cfe-commits
Ping -- AlexDenisov Software Engineer, http://lowlevelbits.org > On 06 Aug 2015, at 18:15, Hans Wennborg wrote: > > Hi Alex, > > What crash is that? I don't see any PR number in the commit. > > Richard, what's your owner's opinion? > > On Wed, Aug 5, 2015 at 9:54 PM, AlexDenisov <1101.deb...@

Re: r244193 - [ObjC] Circular containers: add support of subclasses

2015-08-06 Thread AlexDenisov via cfe-commits
> Ah, you were referring to > http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20150727/134471.html Yes, that is correct :) > Sorry, email is hard to keep up with sometimes :-) No worries, I do understand ;) -- AlexDenisov Software Engineer, http://lowlevelbits.org > On 06 Aug 2015, a

Re: r244193 - [ObjC] Circular containers: add support of subclasses

2015-08-06 Thread Hans Wennborg via cfe-commits
Ah, you were referring to http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20150727/134471.html Sorry, email is hard to keep up with sometimes :-) On Thu, Aug 6, 2015 at 9:15 AM, Hans Wennborg wrote: > Hi Alex, > > What crash is that? I don't see any PR number in the commit. > > Richar

Re: r244193 - [ObjC] Circular containers: add support of subclasses

2015-08-05 Thread AlexDenisov
Hi, Hans. The patch fixes crash reported by Argyrios. Might be a candidate for release_37. -- AlexDenisov Software Engineer, http://lowlevelbits.org > On 06 Aug 2015, at 06:51, Alex Denisov <1101.deb...@gmail.com> wrote: > > Author: alexdenisov > Date: Wed Aug 5 23:51:14 2015 > New Revision: 244