Re: [modules] PR24954

2016-03-18 Thread Vassil Vassilev via cfe-commits
On 16/03/16 03:22, Richard Smith wrote: Please restrict this to the case where the function template is a friend (check D->getFriendObjectKind()). Otherwise, this looks good to me. Thanks! Done and committed in r263634. Thanks! On Mon, Mar 7, 2016 at 2:23 AM, Vassil Vassilev wrote: ping...

Re: [modules] PR24954

2016-03-15 Thread Richard Smith via cfe-commits
Please restrict this to the case where the function template is a friend (check D->getFriendObjectKind()). Otherwise, this looks good to me. Thanks! On Mon, Mar 7, 2016 at 2:23 AM, Vassil Vassilev wrote: > ping... > > On 22/02/16 21:51, Vassil Vassilev wrote: >> >> On 02/02/16 02:52, Richard Smit

Re: [modules] PR24954

2016-03-07 Thread Vassil Vassilev via cfe-commits
ping... On 22/02/16 21:51, Vassil Vassilev wrote: On 02/02/16 02:52, Richard Smith via cfe-commits wrote: On Thu, Jan 28, 2016 at 8:23 AM, Vassil Vassilev wrote: Would this patch be more reasonable? It follows what RegisterTemplateSpecialization (introduced in r245779) does. AFAICT this adds

Re: [modules] PR24954

2016-02-22 Thread Vassil Vassilev via cfe-commits
On 02/02/16 02:52, Richard Smith via cfe-commits wrote: On Thu, Jan 28, 2016 at 8:23 AM, Vassil Vassilev wrote: Would this patch be more reasonable? It follows what RegisterTemplateSpecialization (introduced in r245779) does. AFAICT this adds an update record far less often. It's still adding

Re: [modules] PR24954

2016-02-01 Thread Richard Smith via cfe-commits
On Thu, Jan 28, 2016 at 8:23 AM, Vassil Vassilev wrote: > Would this patch be more reasonable? It follows what > RegisterTemplateSpecialization (introduced in r245779) does. AFAICT this > adds an update record far less often. It's still adding redundant update records. We'll write the appropriate

Re: [modules] PR24954

2016-01-28 Thread Vassil Vassilev via cfe-commits
Would this patch be more reasonable? It follows what RegisterTemplateSpecialization (introduced in r245779) does. AFAICT this adds an update record far less often. --Vassil On 12/12/15 16:13, Vassil Vassilev wrote: I couldn't find GetDecl routine in the ASTWriter. Could you elaborate? Assuming