On 10/1/21 2:59 PM, Josh Stone wrote:
> On 9/30/21 4:15 PM, Mehdi AMINI via llvm-dev wrote:
>> On Thu, Sep 30, 2021 at 4:09 PM Brian Cain wrote:
>>>
>>>
>>>
>>> On Thu, Sep 30, 2021, 6:04 PM Brian Cain wrote:
Does something like Rust's "bors" bot satisfy the herald rules need?
>>>
>>>
>
On 9/30/21 4:15 PM, Mehdi AMINI via llvm-dev wrote:
> On Thu, Sep 30, 2021 at 4:09 PM Brian Cain wrote:
>>
>>
>>
>> On Thu, Sep 30, 2021, 6:04 PM Brian Cain wrote:
>>>
>>> Does something like Rust's "bors" bot satisfy the herald rules need?
>>
>>
>>
>> sorry, maybe I was thinking of the high-five
Hi folks,
Arcanist not working any longer is really unfortunate. Phroge also has a
fork of Arcanist, however I haven't seen any SSL-related patches:
https://we.phorge.it/source/arcanist/browse/master/
1) Replacement for Herald rules.
I suppose the notification problem is solvable. I just took a
I would like to add a third blocker to Mehdi's list:
3) We first would need to finish our ongoing Bugzilla to GitHub Issues
migration: At the moment the plan is to use the old bug ID in bugzilla as
issue ID on GitHub. However issues and Pull Requests share the same
namespace. So once we start usin
On Thu, Sep 30, 2021, 6:04 PM Brian Cain wrote:
> Does something like Rust's "bors" bot satisfy the herald rules need?
>
sorry, maybe I was thinking of the high-five bot. And it looks like that's
not quite a match for herald.
> re: #2 I have done this on GHE and it's mildly awkward but it do
Does something like Rust's "bors" bot satisfy the herald rules need?
re: #2 I have done this on GHE and it's mildly awkward but it does work.
And yes normalizing force pushes is the unfortunate state of GitHub PRs.
Comments are preserved. Code-anchored comments like review comments are
marked as
How far are we from a workflow that leverages Github's Pull Requests? Is
there some consensus that it's a desired end goal, but some features are
missing? Or do we prefer to use a workflow like this for the long term?
On Thu, Sep 30, 2021, 4:54 PM Chris Tetreault via llvm-dev <
llvm-...@lists.ll
As I, and others have noticed, it seems that as of today, there’s some
certificate issue with arcanist. (See:
https://lists.llvm.org/pipermail/llvm-dev/2021-September/153019.html) The fix
seems simple, and a PR is up, but looking through the PR activity, it seems
that the PR will not be accepte
+1 to the review experience in Github being far worse than Phabricator,
with basically all my specific concerns already being covered in this
thread. I just wanted to add that our downstream LLVM port is based in a
local Github Enterprise instance, and I find it far harder to review and
respond to
On Thu, Sep 30, 2021 at 8:05 PM Hubert Tong
wrote:
>
> On Thu, Sep 30, 2021 at 6:56 PM Mehdi AMINI via cfe-commits
> wrote:
>>
>> We talked about this with the IWG (Infrastructure Working Group) just
>> last week coincidentally.
>> Two major blocking tracks that were identified at the roundtable
On Thu, Sep 30, 2021 at 6:56 PM Mehdi AMINI via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> We talked about this with the IWG (Infrastructure Working Group) just
> last week coincidentally.
> Two major blocking tracks that were identified at the roundtable
> during the LLVM Dev Meeting exac
On Thu, Sep 30, 2021 at 4:09 PM Brian Cain wrote:
>
>
>
> On Thu, Sep 30, 2021, 6:04 PM Brian Cain wrote:
>>
>> Does something like Rust's "bors" bot satisfy the herald rules need?
>
>
>
> sorry, maybe I was thinking of the high-five bot. And it looks like that's
> not quite a match for herald.
We talked about this with the IWG (Infrastructure Working Group) just
last week coincidentally.
Two major blocking tracks that were identified at the roundtable
during the LLVM Dev Meeting exactly 2 years ago are still an issue
today:
1) Replacement for Herald rules. This is what allows us to subs
On Tue, 24 Aug 2021 at 17:30, James Y Knight wrote:
> Yes, the Gerrit hosting which Go uses ("googlesource.com") only permits a
> google-account login as a matter of policy. But that's not a restriction of
> Gerrit itself -- it can perfectly well be configured to use a github login.
>
Ah, awesom
On Tue, Aug 24, 2021 at 7:33 AM Renato Golin wrote:
> The main problem with that (Go) solution is that the Gerrit install
> doesn't single-sign-on with Github accounts, it asked me for my Google
> account. We shouldn't ask people to create more accounts if we want
> integration with Github. I gue
On Tue, Aug 24, 2021 at 8:18 AM Renato Golin wrote:
>
> On Tue, 24 Aug 2021 at 12:49, Aaron Ballman wrote:
>>
>> > A minor issue is that the messages Gerrit sends to Github are a bit
>> > pointless "Message from PersonA: (1 comment)". It would be better if the
>> > integration either works (lik
On Tue, 24 Aug 2021 at 12:49, Aaron Ballman wrote:
> > A minor issue is that the messages Gerrit sends to Github are a bit
> pointless "Message from PersonA: (1 comment)". It would be better if the
> integration either works (like adding comments to a specific line or
> updating the commits) or n
On Tue, Aug 24, 2021 at 7:33 AM Renato Golin via cfe-commits
wrote:
>
> On Mon, 23 Aug 2021 at 18:56, James Y Knight wrote:
>>
>> If phabricator/phorge do turn out to be non-viable in the future, I think we
>> may want to reopen the option of moving to Gerrit for the primary
>> code-review plat
On Mon, 23 Aug 2021 at 18:56, James Y Knight wrote:
> If phabricator/phorge do turn out to be non-viable in the future, I think
> we may want to reopen the option of moving to Gerrit for the primary
> code-review platform.
>
> I'll note that the Golang folks are using Gerrit as their review platf
If phabricator/phorge do turn out to be non-viable in the future, I think
we may want to reopen the option of moving to Gerrit for the primary
code-review platform.
I'll note that the Golang folks are using Gerrit as their review platform,
and they have a GitHub bot setup to translate GH pull-requ
On Wed, 18 Aug 2021 at 18:17, MyDeveloper Day via llvm-dev <
llvm-...@lists.llvm.org> wrote:
> But unless I missed this, was there any discussion regarding the recent
> "Winding Down" announcement of Phabricator? and what it might mean for us
> in LLVM
>
I think we have our own self-hosted versio
21 matches
Mail list logo
