Re: [libcxx] r328245 - Use DoNotOptimize to prevent new/delete elision.

2018-03-24 Thread Eric Fiselier via cfe-commits
Woops. I misread the name of the test. I just committed a fix. Thanks for the heads up. /Eric On Sat, Mar 24, 2018 at 4:44 PM, Francois Pichet wrote: > You didn't update allocator.members\construct.pass.cpp in your patch. > > > On Sat, Mar 24, 2018 at 6:41 PM, Eric Fiselier wrote: > >> Still?

Re: [libcxx] r328245 - Use DoNotOptimize to prevent new/delete elision.

2018-03-24 Thread Francois Pichet via cfe-commits
You didn't update allocator.members\construct.pass.cpp in your patch. On Sat, Mar 24, 2018 at 6:41 PM, Eric Fiselier wrote: > Still? > > I would of hoped this patch fixed it. > > Could you provide the test output? > > /Eric > > On Sat, Mar 24, 2018 at 4:39 PM, Francois Pichet > wrote: > >> Hi,

Re: [libcxx] r328245 - Use DoNotOptimize to prevent new/delete elision.

2018-03-24 Thread Eric Fiselier via cfe-commits
Still? I would of hoped this patch fixed it. Could you provide the test output? /Eric On Sat, Mar 24, 2018 at 4:39 PM, Francois Pichet wrote: > Hi, > > I am seeing failure on this test too. > test\std\utilities\memory\default.allocator\allocator.member > s\construct.pass.cpp > > For the s

Re: [libcxx] r328245 - Use DoNotOptimize to prevent new/delete elision.

2018-03-24 Thread Francois Pichet via cfe-commits
Hi, I am seeing failure on this test too. test\std\utilities\memory\default.allocator\allocator. members\construct.pass.cpp For the same reason : new optimized away. On Thu, Mar 22, 2018 at 5:28 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: