Re: [libcxx] r282345 - Use __attribute__((internal_linkage)) when available.

Thanks Eric! > On Oct 12, 2016, at 9:18 PM, Eric Fiselier wrote: > > Sure, I've reverted the change in r284101. > > I'll try and respond in detail tomorrow. > > /Eric > > On Wed, Oct 12, 2016 at 9:57 PM, Mehdi Amini > wrote: > Hi Eric, > > This is not clear to

Re: [libcxx] r282345 - Use __attribute__((internal_linkage)) when available.

Sure, I've reverted the change in r284101. I'll try and respond in detail tomorrow. /Eric On Wed, Oct 12, 2016 at 9:57 PM, Mehdi Amini wrote: > Hi Eric, > > This is not clear to me that this patch is correct as-is. > > See the last message in the thread: http://lists.llvm.org/ > pipermail/cfe-

Re: [libcxx] r282345 - Use __attribute__((internal_linkage)) when available.

Hi Eric, This is not clear to me that this patch is correct as-is. See the last message in the thread: http://lists.llvm.org/pipermail/cfe-dev/2016-July/049985.html I think we should reach a consensus on the right course of actio