Re: [libcxx] r250319 - [libcxx] Make it drastically simpler to link libc++.

2015-12-30 Thread Nico Weber via cfe-commits
gen_link_script.py is missing a license header. On Thu, Oct 22, 2015 at 5:39 PM, Alexey Samsonov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Seems to work now, thanks for the quick fix! > > On Thu, Oct 22, 2015 at 1:57 PM, Eric Fiselier wrote: > >> Hi Alexey, >> >> Please confirm that

Re: [libcxx] r250319 - [libcxx] Make it drastically simpler to link libc++.

2015-10-22 Thread Alexey Samsonov via cfe-commits
Seems to work now, thanks for the quick fix! On Thu, Oct 22, 2015 at 1:57 PM, Eric Fiselier wrote: > Hi Alexey, > > Please confirm that this works for you now after r251063. Sorry for the > breakage. > > /Eric > > On Thu, Oct 22, 2015 at 9:23 AM, Alexey Samsonov > wrote: > >> After this change

Re: [libcxx] r250319 - [libcxx] Make it drastically simpler to link libc++.

2015-10-22 Thread Eric Fiselier via cfe-commits
Hi Alexey, Please confirm that this works for you now after r251063. Sorry for the breakage. /Eric On Thu, Oct 22, 2015 at 9:23 AM, Alexey Samsonov wrote: > After this change I am unable to configure libcxx as external project from > compiler-rt with extra build flags. > The problem is gen_lin

Re: [libcxx] r250319 - [libcxx] Make it drastically simpler to link libc++.

2015-10-22 Thread Alexey Samsonov via cfe-commits
After this change I am unable to configure libcxx as external project from compiler-rt with extra build flags. The problem is gen_link_script.py is invoked with incorrect number of arguments: LIBCXX_CXX_ABI_LIBNAME is automatically deduced to be "none", and LIBCXX_CXX_ABI_LIBRARY which is passed to

RE: [libcxx] r250319 - [libcxx] Make it drastically simpler to link libc++.

2015-10-21 Thread Eric Fiselier via cfe-commits
Thanks. I'll look to see if any other LLVM projects have bumped the CMake version to 3 yet. If so that's the direction I will head. On Oct 20, 2015 9:39 PM, "Hahnfeld, Jonas" wrote: > > -Original Message- > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > >

RE: [libcxx] r250319 - [libcxx] Make it drastically simpler to link libc++.

2015-10-21 Thread Hahnfeld, Jonas via cfe-commits
> -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of Eric Fiselier via cfe-commits > Sent: Wednesday, October 14, 2015 9:54 PM > To: cfe-commits@lists.llvm.org > Subject: [libcxx] r250319 - [libcxx] Make it drastically simpler to link > libc++