Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

The tests are passing now . Will now try to add back the piece of test that was removed and see whether it works. On Thu, Aug 20, 2015 at 2:00 AM, Alexander Kornienko wrote: > After looking at the code once again, I found an o

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

After looking at the code once again, I found an obvious use-after-free bug which could have caused all of this (and for some reason only manifested itself on Darwin). r245524 should fix the issue. On Thu, Aug 20, 2015 at 1:44 AM, Justin Bogner wrote: > That didn't work either - both tests are s

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

That didn't work either - both tests are still failing. Alexander Kornienko writes: > Something weird happens with options reading. Submitted a possible workaround > in r245517. > > On Thu, Aug 20, 2015 at 12:48 AM, Justin Bogner wrote: > > Locally, it seems to fail two tests now: > >

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

Something weird happens with options reading. Submitted a possible workaround in r245517. On Thu, Aug 20, 2015 at 12:48 AM, Justin Bogner wrote: > Locally, it seems to fail two tests now: > > Failing Tests (2): > Clang Tools :: clang-tidy/modernize-use-nullptr-basic.cpp > Clang Tools ::

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

Justin Bogner writes: > Locally, it seems to fail two tests now: > > Failing Tests (2): > Clang Tools :: clang-tidy/modernize-use-nullptr-basic.cpp > Clang Tools :: clang-tidy/modernize-use-nullptr.cpp > > I'll poke at it for a minute and see if there's something obvious I can > do, but ru

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

Locally, it seems to fail two tests now: Failing Tests (2): Clang Tools :: clang-tidy/modernize-use-nullptr-basic.cpp Clang Tools :: clang-tidy/modernize-use-nullptr.cpp I'll poke at it for a minute and see if there's something obvious I can do, but running the run line manually just seem

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

Yep, works for me locally. Thanks for fixing it. Pete > On Aug 19, 2015, at 3:24 PM, Alexander Kornienko wrote: > > I've committed the check with minor modifications and without the offending > test in r245511. Could you verify that it works in your setup? > > -- Alex > > On Wed, Aug 19, 201

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

I've committed the check with minor modifications and without the offending test in r245511. Could you verify that it works in your setup? -- Alex On Wed, Aug 19, 2015 at 11:41 PM, Pete Cooper wrote: > > On Aug 19, 2015, at 2:38 PM, Alexander Kornienko > wrote: > > The check has been reverted

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

> On Aug 19, 2015, at 2:38 PM, Alexander Kornienko wrote: > > The check has been reverted in r245493. Sorry for the breakage, I was hoping > that this commit fixes it. No problem. Thanks for taking a look. If you think the rest of the code is good and want to land it again then thats fine.

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

The check has been reverted in r245493. Sorry for the breakage, I was hoping that this commit fixes it. On Wed, Aug 19, 2015 at 10:31 PM, Pete Cooper wrote: > Looks like its only a single test thats failing. > > Would you mind if I remove this piece of the test until we can get to the > bottom o

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

Looks like its only a single test thats failing. Would you mind if I remove this piece of the test until we can get to the bottom of it? void test_macro_expansion4() { #define MY_NULL NULL int *p = MY_NULL; // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: use nullptr [modernize-use-nullptr] /

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

Hi Alexander We’re still getting a green dragon failure on the null ptr check test. Mind taking a look? http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/10351/consoleFull#50560140149ba4694-19c4-4d7e-bec5-911270d8a58c