Looks good. Thanks!
Matthew
From: Sam McCall
Sent: Tuesday, May 19, 2020 9:19 AM
To: Voss, Matthew
Cc: cfe-commits ; Sam McCall
Subject: Re: [clang-tools-extra] 9b88a19 - [clangd] Add CSV export for trace
metrics
Sorry about that Matthew, I think
Sorry about that Matthew, I think 5bc0c8f009261425a should have fixed this
(giving up on stringview entirely). It fixed the other windows based bots.
If it's no good, please do revert if you can, I'll check on it shortly too.
On Tue, May 19, 2020, 6:14 PM Voss, Matthew wrote:
> Hi Sam,
>
> This
Hi Sam,
This commit's tests are failing to compile on the PS4 Windows bot and our
internal CI. Could you take a look? Just FYI, I may end up reverting this after
an hour or so to unclog our CI.
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/32433
Than
