Re: [clang] 43606ef - Suppress an "unused variable" warning in release build

2020-03-23 Thread David Blaikie via cfe-commits
___ >> From: David Blaikie >> Sent: Sunday, March 22, 2020 03:32 >> To: Mikhail Maltsev; Mikhail Maltsev >> Cc: cfe-commits >> Subject: Re: [clang] 43606ef - Suppress an "unused variable" warning in >> release build >> >> Does "is

Re: [clang] 43606ef - Suppress an "unused variable" warning in release build

2020-03-23 Thread David Blaikie via cfe-commits
CoprocNoAP. > > -- > Regards, >Mikhail Maltsev > > > From: David Blaikie > Sent: Sunday, March 22, 2020 03:32 > To: Mikhail Maltsev; Mikhail Maltsev > Cc: cfe-commits > Subject: Re: [clang] 43606ef - Supp

Re: [clang] 43606ef - Suppress an "unused variable" warning in release build

2020-03-23 Thread Mikhail Maltsev via cfe-commits
"unused variable" warning in release build Does "isIntegerConstantExpr" have side effects that are desired/necessary? Otherwise please change this to roll the isIntegerConstantExpr into the assert (so that it is only executed when asserts are enabled) On Tue, Mar 10, 2020 at 10:1

Re: [clang] 43606ef - Suppress an "unused variable" warning in release build

2020-03-21 Thread David Blaikie via cfe-commits
Does "isIntegerConstantExpr" have side effects that are desired/necessary? Otherwise please change this to roll the isIntegerConstantExpr into the assert (so that it is only executed when asserts are enabled) On Tue, Mar 10, 2020 at 10:11 AM Mikhail Maltsev via cfe-commits < cfe-commits@lists.llvm