Re: [clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

2020-11-06 Thread Richard Smith via cfe-commits
On Fri, 6 Nov 2020 at 13:30, Alex L wrote: > Hi Rchard, > > Some of our code started triggering the warning you added in this code, > but I'm not sure if the warning is actually valid or not in this case: > > https://godbolt.org/z/9fxs3K > > namespace geo { > template > class optional { > o

Re: [clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

2020-11-06 Thread Alex L via cfe-commits
Hi Rchard, Some of our code started triggering the warning you added in this code, but I'm not sure if the warning is actually valid or not in this case: https://godbolt.org/z/9fxs3K namespace geo { template class optional { optional() { } ~optional(); }; } template geo::optional::~optiona

Re: [clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

2020-02-13 Thread Richard Smith via cfe-commits
Thanks, yes, fixed in llvmorg-11-init-3043-gc1394afb8df. On Thu, 13 Feb 2020 at 02:58, Kostya Serebryany via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Could this have caused a new ubsan failure? > > clang/lib/AST/NestedNameSpecifier.cpp:485:23: runtime error: null pointer > passed as ar

Re: [clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

2020-02-12 Thread Kostya Serebryany via cfe-commits
Could this have caused a new ubsan failure? clang/lib/AST/NestedNameSpecifier.cpp:485:23: runtime error: null pointer passed as argument 2, which is declared to never be null http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/38698/steps/check-clang%20ubsan/logs/stdio On Fri, F

Re: [clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

2020-02-10 Thread Nico Weber via cfe-commits
On Sun, Feb 9, 2020 at 2:34 PM Richard Smith wrote: > On Sun, 9 Feb 2020, 01:09 Nico Weber via cfe-commits, < > cfe-commits@lists.llvm.org> wrote: > >> Our code fails to build with "destructor cannot be declared using a type >> alias" after this, without us changing language mode or anything. >>

Re: [clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

2020-02-10 Thread Richard Smith via cfe-commits
On Sun, 9 Feb 2020 at 11:33, Richard Smith wrote: > On Sun, 9 Feb 2020, 01:09 Nico Weber via cfe-commits, < > cfe-commits@lists.llvm.org> wrote: > >> Our code fails to build with "destructor cannot be declared using a type >> alias" after this, without us changing language mode or anything. >> >>

Re: [clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

2020-02-09 Thread Richard Smith via cfe-commits
On Sun, 9 Feb 2020, 01:09 Nico Weber via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > Our code fails to build with "destructor cannot be declared using a type > alias" after this, without us changing language mode or anything. > > Is that intended? > Can you provide a sketch of what you we

Re: [clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

2020-02-08 Thread Nico Weber via cfe-commits
(Also, it'd be nice if the "destructor cannot be declared using a type alias" diag had a fixit attached to it :) ) On Sat, Feb 8, 2020 at 7:09 PM Nico Weber wrote: > Our code fails to build with "destructor cannot be declared using a type > alias" after this, without us changing language mode or

Re: [clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

2020-02-08 Thread Nico Weber via cfe-commits
Our code fails to build with "destructor cannot be declared using a type alias" after this, without us changing language mode or anything. Is that intended? Can this be a default-error-mapped warning so that projects have some incremental transition path for this? On Fri, Feb 7, 2020 at 9:41 PM R