Re: [PATCH] fix parentheses location in a CXXConstructExpr

2015-09-03 Thread Richard Smith via cfe-commits
On Thu, Sep 3, 2015 at 2:26 PM, Olivier Goffart wrote: > On Thursday 3. September 2015 13:41:12 Richard Smith wrote: > > On Thu, Sep 3, 2015 at 8:58 AM, Manuel Klimek wrote: > > > On Tue, Sep 1, 2015 at 12:31 AM Olivier Goffart > wrote: > > >> On Monday 31. August 2015 08:07:58 Manuel Klimek wr

Re: [PATCH] fix parentheses location in a CXXConstructExpr

2015-09-03 Thread Olivier Goffart via cfe-commits
On Thursday 3. September 2015 13:41:12 Richard Smith wrote: > On Thu, Sep 3, 2015 at 8:58 AM, Manuel Klimek wrote: > > On Tue, Sep 1, 2015 at 12:31 AM Olivier Goffart wrote: > >> On Monday 31. August 2015 08:07:58 Manuel Klimek wrote: > >> > On Sat, Aug 29, 2015 at 12:23 PM Olivier Goffart via cf

Re: [PATCH] fix parentheses location in a CXXConstructExpr

2015-09-03 Thread Richard Smith via cfe-commits
On Thu, Sep 3, 2015 at 8:58 AM, Manuel Klimek wrote: > On Tue, Sep 1, 2015 at 12:31 AM Olivier Goffart wrote: > >> On Monday 31. August 2015 08:07:58 Manuel Klimek wrote: >> > On Sat, Aug 29, 2015 at 12:23 PM Olivier Goffart via cfe-commits < >> > >> > cfe-commits@lists.llvm.org> wrote: >> > > H

Re: [PATCH] fix parentheses location in a CXXConstructExpr

2015-09-03 Thread Manuel Klimek via cfe-commits
On Tue, Sep 1, 2015 at 12:31 AM Olivier Goffart wrote: > On Monday 31. August 2015 08:07:58 Manuel Klimek wrote: > > On Sat, Aug 29, 2015 at 12:23 PM Olivier Goffart via cfe-commits < > > > > cfe-commits@lists.llvm.org> wrote: > > > Hi, > > > > > > Please review the attached patch. > > > > > > In

Re: [PATCH] fix parentheses location in a CXXConstructExpr

2015-08-31 Thread Olivier Goffart via cfe-commits
On Monday 31. August 2015 08:07:58 Manuel Klimek wrote: > On Sat, Aug 29, 2015 at 12:23 PM Olivier Goffart via cfe-commits < > > cfe-commits@lists.llvm.org> wrote: > > Hi, > > > > Please review the attached patch. > > > > In Sema::BuildCXXFunctionalCastExpr, if the class has a destructor, the >

Re: [PATCH] fix parentheses location in a CXXConstructExpr

2015-08-31 Thread Manuel Klimek via cfe-commits
On Sat, Aug 29, 2015 at 12:23 PM Olivier Goffart via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi, > > Please review the attached patch. > > In Sema::BuildCXXFunctionalCastExpr, if the class has a destructor, the > Op.SrcExpr might be a CXXBindTemporaryExpr which we need to unwrap. > > In