Re: [PATCH] Restructure the propagation of -fPIC/-fPIE.

2016-06-22 Thread Sean Silva via cfe-commits
-def fpie : Flag<["-"], "fpie">, Group; +def fpie : Flag<["-"], "fpie">, Group, Flags<[CC1Option]>; I don't think this is the right solution as "-fpie" doesn't mean the same thing to the driver and CC1 is sort of confusing (in CC1 it doesn't mean anything by itself). Can you change the existing `

Re: [PATCH] Restructure the propagation of -fPIC/-fPIE.

2016-06-22 Thread Joerg Sonnenberger via cfe-commits
On Wed, Jun 22, 2016 at 08:06:06AM -0400, Rafael Espíndola wrote: > On 21 June 2016 at 19:04, Joerg Sonnenberger via cfe-commits > wrote: > > On Tue, Jun 21, 2016 at 06:53:03PM -0400, Rafael Espíndola via cfe-commits > > wrote: > >> diff --git a/lib/Frontend/InitPreprocessor.cpp > >> b/lib/Front

Re: [PATCH] Restructure the propagation of -fPIC/-fPIE.

2016-06-22 Thread Rafael Espíndola via cfe-commits
On 21 June 2016 at 19:04, Joerg Sonnenberger via cfe-commits wrote: > On Tue, Jun 21, 2016 at 06:53:03PM -0400, Rafael Espíndola via cfe-commits > wrote: >> diff --git a/lib/Frontend/InitPreprocessor.cpp >> b/lib/Frontend/InitPreprocessor.cpp >> index 27ef59a..6b93c69 100644 >> --- a/lib/Fronten

Re: [PATCH] Restructure the propagation of -fPIC/-fPIE.

2016-06-21 Thread Joerg Sonnenberger via cfe-commits
On Tue, Jun 21, 2016 at 06:53:03PM -0400, Rafael Espíndola via cfe-commits wrote: > diff --git a/lib/Frontend/InitPreprocessor.cpp > b/lib/Frontend/InitPreprocessor.cpp > index 27ef59a..6b93c69 100644 > --- a/lib/Frontend/InitPreprocessor.cpp > +++ b/lib/Frontend/InitPreprocessor.cpp > @@ -873,10