Re: [PATCH] D9285: Add a KeepVirtual option to misc-use-override

2015-08-18 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. In http://reviews.llvm.org/D9285#224690, @ehsan wrote: > Sorry, I kind of dropped the ball here! > > At Mozilla we ended up deciding on allowing only a maximum of one of virtual, > final or override per function declaration, similar to the Google coding > style, so we wo

Re: [PATCH] D9285: Add a KeepVirtual option to misc-use-override

2015-08-14 Thread Ehsan Akhgari via cfe-commits
ehsan added a comment. Sorry, I kind of dropped the ball here! At Mozilla we ended up deciding on allowing only a maximum of one of virtual, final or override per function declaration, similar to the Google coding style, so we won't need the KeepVirtual option. Should I still add it neverthele

Re: [PATCH] D9285: Add a KeepVirtual option to misc-use-override

2015-08-14 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. What's the status of this patch? http://reviews.llvm.org/D9285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits