Re: [PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-08-05 Thread Hans Wennborg via cfe-commits
On Wed, Aug 5, 2020 at 6:26 PM Hiroshi Yamauchi via llvm-commits wrote: > > > > On Wed, Aug 5, 2020 at 8:30 AM Hans Wennborg via Phabricator > wrote: >> >> hans added a comment. >> >> In D84782#2191429 , @yamauchi wrote: >> >> > In D84782#2191243

Re: [PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-08-05 Thread Hiroshi Yamauchi via cfe-commits
On Wed, Aug 5, 2020 at 8:30 AM Hans Wennborg via Phabricator < revi...@reviews.llvm.org> wrote: > hans added a comment. > > In D84782#2191429 , @yamauchi > wrote: > > > In D84782#2191243 , @MaskRay > wrote: > > > >>

Re: [PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-29 Thread Xinliang David Li via cfe-commits
right. It occurred to me during review, but did not think of the hard coded values in proftext depends on LE. On Wed, Jul 29, 2020 at 3:04 PM Hiroshi Yamauchi via Phabricator < revi...@reviews.llvm.org> wrote: > yamauchi added a comment. > > Builtbot failure: > http://lab.llvm.org:8011/builders/c