Re: [PATCH] D79302: [clangd] Propogate context in LSPServer tests

2020-05-03 Thread Kadir Çetinkaya via cfe-commits
i was trying to provide a more generic "callback" mechanism, but you are right, it is not needed for this test. going to keep context prop logic though, as it might be necessary later on. SG? On Sun, May 3, 2020 at 9:09 PM Sam McCall via Phabricator < revi...@reviews.llvm.org> wrote: > sammccall

Re: [PATCH] D79302: [clangd] Propogate context in LSPServer tests

2020-05-03 Thread Sam McCall via cfe-commits
On Sun, May 3, 2020, 3:22 PM Kadir Cetinkaya via Phabricator < revi...@reviews.llvm.org> wrote: > kadircet marked 3 inline comments as done. > kadircet added inline comments. > > > > Comment at: clang-tools-extra/clangd/unittests/LSPClient.cpp:120 > + auto Req = std::move(Req