Re: [PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

2019-10-29 Thread Reid Kleckner via cfe-commits
On Mon, Oct 28, 2019 at 4:42 PM David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > If the intended behavior is to show the crash at the call site like >> LangRef in the patch suggest then line 0 will certainly not achieve that. I >> implicitly assumed the wording in LangRef would

Re: [PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

2019-10-28 Thread David Blaikie via cfe-commits
On Thu, Oct 24, 2019 at 3:24 PM Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Oct 24, 2019, at 3:02 PM, David Blaikie via Phabricator < > revi...@reviews.llvm.org> wrote: > > dblaikie added a comment. > > In D67723#1720509 , @a

Re: [PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

2019-10-24 Thread Adrian Prantl via cfe-commits
> On Oct 24, 2019, at 3:02 PM, David Blaikie via Phabricator > wrote: > > dblaikie added a comment. > > In D67723#1720509 , @aprantl wrote: > >> In D67723#1720353 , @rnk wrote: >> >>> In D67723#1717468