Re: [PATCH] D63194: [clangd] Link and initialize target infos

2020-04-14 Thread Filipe Cabecinhas via cfe-commits
Hi Kadir, Thank you for looking into this. Unfortunately, I can't repro this anymore. I wonder if I had a weird stale clangd or something. Current test (now changed to armv7) does set the target properly. When I tried last time, it wasn't setting it, and was defaulting to my system's (darwin). Th

Re: [PATCH] D63194: [clangd] Link and initialize target infos

2020-04-11 Thread Kadir Çetinkaya via cfe-commits
Hi Filipe! Thanks for letting me know, I've sent https://reviews.llvm.org/D77944 to enable this in clangd lit config. Regarding the failure, I can't seem to repro on machines I have access to. The premerge-tests also seems to be succeeding, please see https://results.llvm-merge-guard.org/BETA_amd6

Re: [PATCH] D63194: [clangd] Link and initialize target infos

2020-04-10 Thread Filipe Cabecinhas via cfe-commits
Hi Kadir, Can you fix the target_info.test clangd test you committed in this revision, please? I see you've tried fixing it later by adding `REQUIRES: x86-registered-target`, but now it's never running because that feature isn't (ever) set. Here's a buildbot run showing it as unsupported (x86 targ