Re: [PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

2019-08-04 Thread Puyan Lotfi via cfe-commits
https://reviews.llvm.org/D65704 https://reviews.llvm.org/D65708 Thanks! PL On Thu, Aug 1, 2019 at 5:42 PM Jan Korous wrote: > Oh! Interesting! Thanks for investigating this. > > I'm happy to review the patch. > > On Aug 1, 2019, at 5:17 PM, Puyan Lotfi > wrote: > > Hi Jan, Thanks for the foll

Re: [PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

2019-08-02 Thread Puyan Lotfi via cfe-commits
Hi Jan, Thanks for the follow up! Me and Compnerd narrowed down the issue to the inotify file count limit being exceeded as the cause. DirectoryWatcherLinux::create() in DirectoryWatcher-linux.cpp also doesn't properly perror, I'll post a patch for this shortly to print perror info if the file cou

Re: [PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

2019-08-01 Thread Jan Korous via cfe-commits
Oh! Interesting! Thanks for investigating this. I'm happy to review the patch. > On Aug 1, 2019, at 5:17 PM, Puyan Lotfi wrote: > > Hi Jan, Thanks for the follow up! > > Me and Compnerd narrowed down the issue to the inotify file count limit being > exceeded as the cause. DirectoryWatcherLinu