Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

2019-01-08 Thread Joerg Sonnenberger via cfe-commits
On Wed, Jan 09, 2019 at 12:20:06AM +, Kamil Rytarowski via Phabricator via llvm-commits wrote: > krytarowski added inline comments. > > > > Comment at: ELF/Driver.cpp:781 > + } > +} > + > > There is need to add a fallback for a native triple. Not really. T

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

2019-01-08 Thread Joerg Sonnenberger via cfe-commits
On Tue, Jan 08, 2019 at 10:58:37PM +, Alexander Richardson via Phabricator via cfe-commits wrote: > arichardson added inline comments. > > > > Comment at: ELF/Driver.cpp:770 > + // Start with a default initial triple > + Config->TargetTriple = llvm::Triple(getDefaultTarget

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

2019-01-04 Thread Joerg Sonnenberger via cfe-commits
On Fri, Jan 04, 2019 at 02:48:35PM +, Alexander Richardson via Phabricator wrote: > Or if you really need to call the linker directly without specifying > search paths you could also install a shell script as /usr/bin/ld that > passes the appropriate flags to /usr/bin/ld.lld? That's not a hon

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

2019-01-04 Thread Joerg Sonnenberger via cfe-commits
On Fri, Jan 04, 2019 at 05:52:46AM +, Michał Górny via Phabricator via llvm-commits wrote: > mgorny added a comment. > > For the record, another option is to actually fix other software not to call > LD directly. See thousand monkeys. It doesn't really scale. Joerg

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

2019-01-03 Thread Joerg Sonnenberger via cfe-commits
On Thu, Jan 03, 2019 at 10:26:38PM +, Rui Ueyama via Phabricator via cfe-commits wrote: > I see there are pros and cons to not have host-specific config in ld. > That said, if other operating systems can live without host-specific > config in lld, why can't NetBSD do? I really don't like to be

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

2019-01-03 Thread Joerg Sonnenberger via cfe-commits
On Thu, Jan 03, 2019 at 09:38:49PM +, Kamil Rytarowski via Phabricator via cfe-commits wrote: > I think that this place is not the right place to bash GNU ld for performance > issues. I didn't. > I will refer just to slides and paper from Ian Lance Taylor to get overview > why it is unacce

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

2019-01-03 Thread Joerg Sonnenberger via cfe-commits
On Thu, Jan 03, 2019 at 08:31:53PM +, Kamil Rytarowski via Phabricator via cfe-commits wrote: > krytarowski added a comment. > > On 03.01.2019 21:19, Joerg Sonnenberger wrote: > > > On Thu, Jan 03, 2019 at 06:34:22PM +, Kamil Rytarowski via Phabricator > > via cfe-commits wrote: > > >

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

2019-01-03 Thread Joerg Sonnenberger via cfe-commits
On Thu, Jan 03, 2019 at 06:58:41PM +, Kamil Rytarowski via Phabricator wrote: > But the result is that we don't have GNU gold either and are stuck with > 40min linking times of LLVM. It's destructive to productivity and > damages any LLVM related development. The reason noone cared much about

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

2019-01-03 Thread Joerg Sonnenberger via cfe-commits
On Thu, Jan 03, 2019 at 06:34:22PM +, Kamil Rytarowski via Phabricator via cfe-commits wrote: > krytarowski added a comment. > > Actually I find it frustrating and unfair as GNU ld doesn't have builtin > knowledge either.. it's passed with gross 'super hack' comments from build > scripts...