Re: [PATCH] D54310: Make clang-based tools find libc++ on MacOS

2018-11-12 Thread Sam McCall via cfe-commits
On Mon, Nov 12, 2018, 20:53 George Karpenkov via Phabricator < revi...@reviews.llvm.org wrote: > george.karpenkov added a comment. > > I don't quite understand the need for this patch. > If we are talking about a binary built from source, wouldn't it make more > sense to build libcxx from source a

Re: [PATCH] D54310: Make clang-based tools find libc++ on MacOS

2018-11-12 Thread Ilya Biryukov via cfe-commits
Will take a look, thanks for the revert. On Mon, Nov 12, 2018 at 6:13 PM Jonas Devlieghere via Phabricator < revi...@reviews.llvm.org> wrote: > JDevlieghere added a comment. > > I reverted this because it broke the LLDB bots on GreenDragon: > http://green.lab.llvm.org/green/view/LLDB/ > > > Repos