Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

2018-08-08 Thread David Blaikie via cfe-commits
On Wed, Aug 8, 2018 at 5:00 AM Ilya Biryukov via Phabricator < revi...@reviews.llvm.org> wrote: > ilya-biryukov added a comment. > > In https://reviews.llvm.org/D50154#1191002, @dblaikie wrote: > > > What's the motivation for clangd to differ from clang here? > > > The presentation of diagnostics

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

2018-08-07 Thread Alex L via cfe-commits
On 7 August 2018 at 17:40, Fangrui Song wrote: > > On 2018-08-07, David Blaikie wrote: > >> >> On Tue, Aug 7, 2018 at 4:02 PM Alex L wrote: >> >>On Tue, 7 Aug 2018 at 11:38, David Blaikie wrote: >> >>On Tue, Aug 7, 2018 at 11:22 AM Alex L wrote: >> >>On Tue, 7 Aug 2018

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

2018-08-07 Thread Fangrui Song via cfe-commits
On 2018-08-07, David Blaikie wrote: On Tue, Aug 7, 2018 at 4:02 PM Alex L wrote: On Tue, 7 Aug 2018 at 11:38, David Blaikie wrote: On Tue, Aug 7, 2018 at 11:22 AM Alex L wrote: On Tue, 7 Aug 2018 at 10:52, David Blaikie via cfe-commits < cfe-commits@lists.l

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

2018-08-07 Thread David Blaikie via cfe-commits
On Tue, Aug 7, 2018 at 4:02 PM Alex L wrote: > On Tue, 7 Aug 2018 at 11:38, David Blaikie wrote: > >> >> >> On Tue, Aug 7, 2018 at 11:22 AM Alex L wrote: >> >>> On Tue, 7 Aug 2018 at 10:52, David Blaikie via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >>> On Tue, Aug 7,

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

2018-08-07 Thread Alex L via cfe-commits
On Tue, 7 Aug 2018 at 11:38, David Blaikie wrote: > > > On Tue, Aug 7, 2018 at 11:22 AM Alex L wrote: > >> On Tue, 7 Aug 2018 at 10:52, David Blaikie via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> >>> >>> On Tue, Aug 7, 2018 at 10:33 AM Alex Lorenz via Phabricator < >>> revi...@r

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

2018-08-07 Thread Fangrui Song via cfe-commits
It might be useful to know what other editors do here to know whether this should be a client transformation or baked into the server. Vim syntastic/ale, Emacs flycheck do not seem to do such transformation. What's the editor you are using? On 2018-08-07, Alex L wrote: On Tue, 7 Aug 2018 at 10

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

2018-08-07 Thread David Blaikie via cfe-commits
On Tue, Aug 7, 2018 at 11:22 AM Alex L wrote: > On Tue, 7 Aug 2018 at 10:52, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> >> On Tue, Aug 7, 2018 at 10:33 AM Alex Lorenz via Phabricator < >> revi...@reviews.llvm.org> wrote: >> >>> arphaman added a comment. >>> >>> I

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

2018-08-07 Thread Alex L via cfe-commits
On Tue, 7 Aug 2018 at 10:52, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Tue, Aug 7, 2018 at 10:33 AM Alex Lorenz via Phabricator < > revi...@reviews.llvm.org> wrote: > >> arphaman added a comment. >> >> In https://reviews.llvm.org/D50154#1191002, @dblaikie wrote: >

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

2018-08-07 Thread David Blaikie via cfe-commits
On Tue, Aug 7, 2018 at 10:33 AM Alex Lorenz via Phabricator < revi...@reviews.llvm.org> wrote: > arphaman added a comment. > > In https://reviews.llvm.org/D50154#1191002, @dblaikie wrote: > > > What's the motivation for clangd to differ from clang here? (& if the > first > > letter is going to be

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

2018-08-07 Thread David Blaikie via cfe-commits
What's the motivation for clangd to differ from clang here? (& if the first letter is going to be capitalized, should there be a period at the end? But also the phrasing of most/all diagnostic text isn't in the form of complete sentences, so this might not make sense) On Fri, Aug 3, 2018 at 1:44 P