Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

2018-04-25 Thread Arthur O'Dwyer via cfe-commits
On Wed, Apr 25, 2018 at 7:10 PM, Richard Smith wrote: > On 23 April 2018 at 20:07, John McCall via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> The issue there is that -Wnoisy-in-tests is likely to be useful as a >> cancellation of -Wno-noisy-in-tests, which (as David suggests) migh

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

2018-04-25 Thread Richard Smith via cfe-commits
On 23 April 2018 at 20:07, John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Apr 23, 2018 at 8:23 PM, Richard Smith > wrote: > >> On 23 April 2018 at 16:23, David Blaikie via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> On Mon, Apr 23, 2018 at 4:12 PM John M

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

2018-04-23 Thread John McCall via cfe-commits
On Mon, Apr 23, 2018 at 8:23 PM, Richard Smith wrote: > On 23 April 2018 at 16:23, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Mon, Apr 23, 2018 at 4:12 PM John McCall wrote: >> >>> On Mon, Apr 23, 2018 at 6:32 PM, David Blaikie >>> wrote: >>> On Mon, Apr 2

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

2018-04-23 Thread Richard Smith via cfe-commits
On 23 April 2018 at 16:23, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Apr 23, 2018 at 4:12 PM John McCall wrote: > >> On Mon, Apr 23, 2018 at 6:32 PM, David Blaikie >> wrote: >> >>> On Mon, Apr 23, 2018 at 3:29 PM John McCall via Phabricator < >>> revi...@review

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

2018-04-23 Thread David Blaikie via cfe-commits
On Mon, Apr 23, 2018 at 4:12 PM John McCall wrote: > On Mon, Apr 23, 2018 at 6:32 PM, David Blaikie wrote: > >> On Mon, Apr 23, 2018 at 3:29 PM John McCall via Phabricator < >> revi...@reviews.llvm.org> wrote: >> >>> rjmccall added a comment. >>> >>> In https://reviews.llvm.org/D45766#1076176, @

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

2018-04-23 Thread John McCall via cfe-commits
On Mon, Apr 23, 2018 at 6:32 PM, David Blaikie wrote: > On Mon, Apr 23, 2018 at 3:29 PM John McCall via Phabricator < > revi...@reviews.llvm.org> wrote: > >> rjmccall added a comment. >> >> In https://reviews.llvm.org/D45766#1076176, @dblaikie wrote: >> >> > Is there anything else in the "-w" nam

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

2018-04-23 Thread David Blaikie via cfe-commits
On Mon, Apr 23, 2018 at 3:29 PM John McCall via Phabricator < revi...@reviews.llvm.org> wrote: > rjmccall added a comment. > > In https://reviews.llvm.org/D45766#1076176, @dblaikie wrote: > > > Is there anything else in the "-w" namespace other than the literal "-w" > so > > far? > > > No. This w

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

2018-04-23 Thread David Blaikie via cfe-commits
Is there anything else in the "-w" namespace other than the literal "-w" so far? I mean, I could imagine it might make more sense to default these warnings off & users can turn them on for non-test code, potentially? So "-Wnon-test" might make sense. On Mon, Apr 23, 2018 at 3:22 PM John McCall vi

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

2018-04-23 Thread David Blaikie via cfe-commits
FWIW I don't fundamentalyl object to also having something like -wtest. Probably needs a better name though (unfortunately the double-negative gets confusing... - like you want to describe the set of diagnostics that should not be used in test code, so that as a group might be "-Wnon-test" but then