Re: [PATCH] D41318: Start setting dso_local in clang

2018-01-31 Thread Rafael Avila de Espindola via cfe-commits
Sean Fertile via Phabricator writes: > sfertile added inline comments. > > > > Comment at: clang/lib/CodeGen/CodeGenModule.cpp:750 > + // If we can use a plt entry as the symbol address we can assume it > + // is local. > + if (isa(D) && !CGOpts.NoPLT) > > I d

Re: [PATCH] D41318: Start setting dso_local in clang

2017-12-22 Thread Rafael Avila de Espindola via cfe-commits
Ping. Is this direction OK? Should a put the time to update the existing tests to account for dso_local? I do volunteer to implement the rest of ELF, COFF and MachO once this is in. Cheers, Rafael Rafael Avila de Espindola writes: > Reid Kleckner via Phabricator writes: > >> rnk added inline

Re: [PATCH] D41318: Start setting dso_local in clang

2017-12-18 Thread Rafael Avila de Espindola via cfe-commits
Reid Kleckner via Phabricator writes: > rnk added inline comments. > > > > Comment at: lib/CodeGen/CodeGenModule.cpp:690-692 > + // Only handle ELF for now. > + if (!CGM.getTriple().isOSBinFormatELF()) > +return false; > > Handling COFF here is probably tri