Sean Fertile via Phabricator writes:
> sfertile added inline comments.
>
>
>
> Comment at: clang/lib/CodeGen/CodeGenModule.cpp:750
> + // If we can use a plt entry as the symbol address we can assume it
> + // is local.
> + if (isa(D) && !CGOpts.NoPLT)
>
> I d
Ping.
Is this direction OK? Should a put the time to update the existing tests
to account for dso_local?
I do volunteer to implement the rest of ELF, COFF and MachO once this is
in.
Cheers,
Rafael
Rafael Avila de Espindola writes:
> Reid Kleckner via Phabricator writes:
>
>> rnk added inline
Reid Kleckner via Phabricator writes:
> rnk added inline comments.
>
>
>
> Comment at: lib/CodeGen/CodeGenModule.cpp:690-692
> + // Only handle ELF for now.
> + if (!CGM.getTriple().isOSBinFormatELF())
> +return false;
>
> Handling COFF here is probably tri