Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks

2017-07-05 Thread Shoaib Meenai via cfe-commits
, "reviews+d34972+public+8a22767368a5b...@reviews.llvm.org" , "r...@google.com" Cc: "cfe-commits@lists.llvm.org" , "ztur...@google.com" Subject: Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks If the thinks are not imported, why would it make sense

Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks

2017-07-05 Thread David Majnemer via cfe-commits
g" , " > reviews+d34972+public+8a22767368a5b...@reviews.llvm.org" < > reviews+d34972+public+8a22767368a5b...@reviews.llvm.org>, "r...@google.com" > > Cc: "ztur...@google.com" , "cfe-commits@lists.llvm.org" > > Subject: Re: [PATCH]

Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks

2017-07-05 Thread Shoaib Meenai via cfe-commits
i via Phabricator , "compn...@compnerd.org" , "reviews+d34972+public+8a22767368a5b...@reviews.llvm.org" , "r...@google.com" Cc: "ztur...@google.com" , "cfe-commits@lists.llvm.org" Subject: Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks

Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks

2017-07-05 Thread David Majnemer via cfe-commits
What about the import side? On Mon, Jul 3, 2017 at 10:37 PM Shoaib Meenai via Phabricator via cfe-commits wrote: > smeenai created this revision. > > Under Windows Itanium, we need to export virtual and non-virtual thunks > if the functions being thunked are exported. These thunks would > previo