Re: [PATCH] D34896: Enable the new PM + SamlePGO + ThinLTO testing.

2017-07-11 Thread David Blaikie via cfe-commits
On Mon, Jul 10, 2017 at 10:58 AM Dehao Chen wrote: > This test was originally added in https://reviews.llvm.org/D34721 with > clang change. It's kind of dup of the previous test > (-check-prefix=SAMPLEPGO) in terms of testing the clang bits. But we > want to make sure the new PM has the expected

Re: [PATCH] D34896: Enable the new PM + SamlePGO + ThinLTO testing.

2017-07-10 Thread Dehao Chen via cfe-commits
This test was originally added in https://reviews.llvm.org/D34721 with clang change. It's kind of dup of the previous test (-check-prefix=SAMPLEPGO) in terms of testing the clang bits. But we want to make sure the new PM has the expected behavior. I guess it would be acceptable to remove one of the

Re: [PATCH] D34896: Enable the new PM + SamlePGO + ThinLTO testing.

2017-07-10 Thread David Blaikie via cfe-commits
Does this test any code in Clang? (given the test is being committed without any change in Clang, I'm guessing maybe not) - perhaps this test doesn't belong in Clang's test suite? Looks like changes/functionality in LTOPreLinkDefaultPipeline are tested in test/Other/new-pm-thinlto-defaults.ll at l