For some reason your comments aren't showing up on Phabricator, so replying
via email - hope everybody sees it.
If SPs are now all finalized early - I'm assuming there's some other code
> that finalizes SPs that's no longer needed?
>
Not all of them, just the one before cloning. I wanted to make
I'll let Adrian weigh in - but I suspect, if possible, it'd be better to
just finalize them all once IRGen for the function finishes.
On Tue, May 30, 2017 at 6:02 PM Keno Fischer
wrote:
> For some reason your comments aren't showing up on Phabricator, so
> replying via email - hope everybody sees
If SPs are now all finalized early - I'm assuming there's some other code
that finalizes SPs that's no longer needed?
Also - this seems like a layering/separation issue - does other code call
into the DI as casually/explicitly as this code being added to CGVTables?
(Or should the callback go throu
