Re: [PATCH] D31702: Append -w when LLVM_ENABLE_WARNINGS is Off.

2020-06-04 Thread Vassil Vassilev via cfe-commits
On 6/4/20 6:58 AM, Sean Silva wrote: Can we revert this? In our downstream project we were bitten by this: https://github.com/google/mlir-npcomp/commit/cd7258dbd48bd9254c6741cab2d3f4e36cbd3c84 It seems that now by default anybody that depends on LLVM with CMake will globally get a `-w` passe

Re: [PATCH] D31702: Append -w when LLVM_ENABLE_WARNINGS is Off.

2020-06-03 Thread Sean Silva via cfe-commits
Can we revert this? In our downstream project we were bitten by this: https://github.com/google/mlir-npcomp/commit/cd7258dbd48bd9254c6741cab2d3f4e36cbd3c84 It seems that now by default anybody that depends on LLVM with CMake will globally get a `-w` passed to their compiler. That doesn't seem lik