Not really.
Would you please help me commit it? Also there is another diff for LLVM
part of this bug.
Thanks.
On Wed, Mar 29, 2017 at 1:16 PM, Eric Christopher via Phabricator <
revi...@reviews.llvm.org> wrote:
> echristo accepted this revision.
> echristo added a comment.
> This revision is no
Sounds good to me.
On Sun, Mar 26, 2017, 9:40 AM David Blaikie wrote:
> Yeah, I don't know/mind either way - I think there's a tidy simplicity to
> including exactly what the user wrote on the command line, so don't mind if
> it's not removed, but can see the argument to omit it. I'd probably le
Yeah, I don't know/mind either way - I think there's a tidy simplicity to
including exactly what the user wrote on the command line, so don't mind if
it's not removed, but can see the argument to omit it. I'd probably leave
it in for simplicity.
On Fri, Mar 24, 2017 at 5:48 PM Eric Christopher via
Not sure, that's why I asked. Is it useful? Is it one of those things we
want to remove since it'll be common among all of the TUs that want the
text?
On Fri, Mar 24, 2017 at 3:43 PM Zhizhou Yang via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Sure I can add some more tests here.
>
> For -
Sure I can add some more tests here.
For -grecord-gcc-switches itself, I think maybe we could keep it in
recording, since it is also one of the options from command line?
On Fri, Mar 24, 2017 at 2:54 PM, Eric Christopher via Phabricator <
revi...@reviews.llvm.org> wrote:
> echristo added inline
As Adrian mentioned, this can probably be covered/added to an existing test
case in clang/test/Driver
On Fri, Mar 24, 2017 at 1:57 PM Zhizhou Yang via Phabricator <
revi...@reviews.llvm.org> wrote:
> zhizhouy updated this revision to Diff 93003.
> zhizhouy marked 3 inline comments as done.
> zhiz
I think that's a good idea.
On Tue, Mar 21, 2017 at 5:19 PM Adrian Prantl via Phabricator <
revi...@reviews.llvm.org> wrote:
> aprantl added a comment.
>
> Sorry for being late to the party, but have you looked at
> CodeGenOptions::DwarfDebugFlags? It looks like it almost does what you
> want, bu
