Resubmitted as r326439. Sorry for all the trouble.
We need to hack around the Analyses.def being required by Frontend, but it
would nice to remove this dependency upstream.
On Thu, Mar 1, 2018 at 3:34 PM Benjamin Kramer wrote:
> Frontend depends on StaticAnalyzerCore by
> including "clang/Stat
Frontend depends on StaticAnalyzerCore by
including "clang/StaticAnalyzer/Core/Analyses.def". That's a clear layering
violation, but cmake doesn't model header dependencies. Maybe Analyses.def
should move into its own library.
On Thu, Mar 1, 2018 at 3:07 PM Gábor Horváth via llvm-commits <
llvm-c
I am away from my workstation so I would really appreciate if you could
recommit.
Thanks in advance,
Gábor
2018. márc. 1. 15:28 ezt írta ("Ilya Biryukov" ):
> You're right. We have this extra dependency in our internal build files
> for some reason and I missed that.
> It's totally my fault.
>
>
You're right. We have this extra dependency in our internal build files for
some reason and I missed that.
It's totally my fault.
Should I resubmit the patch that I reverted or you would rather do it
yourself?
On Thu, Mar 1, 2018 at 3:07 PM Gábor Horváth wrote:
>
>
> 2018. márc. 1. 14:58 ezt
2018. márc. 1. 14:58 ezt írta ("Ilya Biryukov" ):
I replied to a commit in the wrong thread (https://reviews.llvm.org/rL326323),
sorry.
Here are the important bits:
This change introduced the following cyclic dependency in the build system:
StaticAnalyzerCore -> CrossTU -> Frontend -> StaticAnaly
I replied to a commit in the wrong thread (https://reviews.llvm.org/rL326323),
sorry.
Here are the important bits:
This change introduced the following cyclic dependency in the build system:
StaticAnalyzerCore -> CrossTU -> Frontend -> StaticAnalyzerCore.
I'm sorry, but I had to revert the commit
