Re: [PATCH] D30415: Fix -mno-altivec cannot overwrite -maltivec option

2017-03-21 Thread Hal Finkel via cfe-commits
On 03/21/2017 12:19 PM, Ulrich Weigand via Phabricator wrote: uweigand added a comment. In https://reviews.llvm.org/D30415#705889, @echristo wrote: In https://reviews.llvm.org/D30415#705196, @uweigand wrote: Well, mainline GCC doesn't have -faltivec at all and never had, I think this was o

Re: [PATCH] D30415: Fix -mno-altivec cannot overwrite -maltivec option

2017-03-16 Thread Eric Christopher via cfe-commits
Great, thanks! Can you make this change instead Sean? :) -eric On Thu, Mar 16, 2017 at 7:20 PM Hal Finkel wrote: > > On 03/16/2017 08:11 PM, Eric Christopher wrote: > > > > On Thu, Mar 16, 2017 at 5:45 PM Hal Finkel wrote: > > > On 03/16/2017 07:40 PM, Eric Christopher wrote: > > > > On Thu, M

Re: [PATCH] D30415: Fix -mno-altivec cannot overwrite -maltivec option

2017-03-16 Thread Hal Finkel via cfe-commits
On 03/16/2017 08:11 PM, Eric Christopher wrote: On Thu, Mar 16, 2017 at 5:45 PM Hal Finkel > wrote: On 03/16/2017 07:40 PM, Eric Christopher wrote: On Thu, Mar 16, 2017 at 5:37 PM Hal Finkel via Phabricator mailto:revi...@reviews.llvm.org>> wrote:

Re: [PATCH] D30415: Fix -mno-altivec cannot overwrite -maltivec option

2017-03-16 Thread Eric Christopher via cfe-commits
On Thu, Mar 16, 2017 at 5:45 PM Hal Finkel wrote: > > On 03/16/2017 07:40 PM, Eric Christopher wrote: > > > > On Thu, Mar 16, 2017 at 5:37 PM Hal Finkel via Phabricator < > revi...@reviews.llvm.org> wrote: > > hfinkel added a comment. > > In https://reviews.llvm.org/D30415#703398, @echristo wrote

Re: [PATCH] D30415: Fix -mno-altivec cannot overwrite -maltivec option

2017-03-16 Thread Hal Finkel via cfe-commits
On 03/16/2017 07:40 PM, Eric Christopher wrote: On Thu, Mar 16, 2017 at 5:37 PM Hal Finkel via Phabricator mailto:revi...@reviews.llvm.org>> wrote: hfinkel added a comment. In https://reviews.llvm.org/D30415#703398, @echristo wrote: > Different suggestion: > > Remove t

Re: [PATCH] D30415: Fix -mno-altivec cannot overwrite -maltivec option

2017-03-16 Thread Eric Christopher via cfe-commits
On Thu, Mar 16, 2017 at 5:37 PM Hal Finkel via Phabricator < revi...@reviews.llvm.org> wrote: > hfinkel added a comment. > > In https://reviews.llvm.org/D30415#703398, @echristo wrote: > > > Different suggestion: > > > > Remove the faltivec option. Even gcc doesn't support it anymore afaict. > > >