On Tue, Jan 17, 2017 at 12:57 AM Manuel Klimek wrote:
> It's by design. Do we want to change this? I always had the impression
> turning on the state changes for the list is a bit noisy, but I'm happy if
> that's not the general sentiment.
>
For approval it's important that that reaches the maili
If we add all state transitions it will only create noise. I will
teach myself to always write "lg" into the text field when approving a
change instead.
On Tue, Jan 17, 2017 at 9:57 AM, Manuel Klimek via cfe-commits
wrote:
> It's by design. Do we want to change this? I always had the impression
>
It's by design. Do we want to change this? I always had the impression
turning on the state changes for the list is a bit noisy, but I'm happy if
that's not the general sentiment.
On Mon, Jan 16, 2017, 11:07 PM Benjamin Kramer wrote:
I got an email where it says that I accepted the revision. Loo
I got an email where it says that I accepted the revision. Looks like
phab didn't add cfe-commits to the list of recipients though :(
On Mon, Jan 16, 2017 at 6:43 PM, David Blaikie wrote:
> Looks like Ben signed off on this on Phab - but the email didn't go to the
> list (making this look like co
Looks like Ben signed off on this on Phab - but the email didn't go to the
list (making this look like code was sent for review, then committed,
without review/approval happening)
Ben: I think Phab doesn't send mail for an approval with no text, so at
least as a workaround you can write something