Re: [PATCH] D27827: [ObjC] CodeGen support for @available on macOS

2017-08-03 Thread Nico Weber via cfe-commits
On Thu, Aug 3, 2017 at 4:13 AM, Alex Lorenz via Phabricator via cfe-commits wrote: > arphaman added a comment. > > In https://reviews.llvm.org/D27827#829661, @thakis wrote: > > > We just noticed that if you call __builtin_available() for the first > time after activating your app's sandbox, the f

Re: [PATCH] D27827: [ObjC] CodeGen support for @available on macOS

2017-02-20 Thread Duncan P. N. Exon Smith via cfe-commits
> On 2017-Feb-20, at 13:11, Alex Lorenz via Phabricator > wrote: > > arphaman added inline comments. > > > > Comment at: lib/CodeGen/CodeGenFunction.h:2479 > > + llvm::Value *EmitObjCIsOSVersionAtLeast(ArrayRef Args); > + > > I think it's better to treat th

Re: [PATCH] D27827: [ObjC] CodeGen support for @available on macOS

2016-12-16 Thread Nico Weber via cfe-commits
https://developer.apple.com/library/content/releasenotes/General/CarbonCoreDeprecations/index.html#//apple_ref/doc/uid/TP40012224-CH1-SW16 explicitly suggests sysctl as replacement when targeting 10.8+, which strongly suggests that it'll work. On Fri, Dec 16, 2016 at 4:37 PM, Erik Pilkington via P