Re: [PATCH] D27387: [libc++] Add a key function for bad_function_call

2016-12-05 Thread Duncan P. N. Exon Smith via cfe-commits
Yes, they are: -- $ clang -dM -x c /dev/null -E -mmacosx-version-min=10.10.0 | grep VERSION_MIN #define __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ 101000 -- However, they're somewhat awkward, extremely vendor-specific, and unrelated to libc++ version numbers. I think a separate ABI flag would

Re: [PATCH] D27387: [libc++] Add a key function for bad_function_call

2016-12-05 Thread Eric Fiselier via cfe-commits
Are the minimum versions detectable in the processor? If so it seems like we could safely configure this change that way. /Eric On Mon, Dec 5, 2016 at 7:37 AM, Duncan Exon Smith wrote: > I haven't looked at the patch, but yes, many developers on our platform > back-deploy to older OS versions (

Re: [PATCH] D27387: [libc++] Add a key function for bad_function_call

2016-12-05 Thread Duncan Exon Smith via cfe-commits
I haven't looked at the patch, but yes, many developers on our platform back-deploy to older OS versions (and we support that via Clang flags, e.g., -miphoneos-version-min=8.0). They always build against the newest SDK/headers. -- dpnes > On Dec 5, 2016, at 00:35, Eric Fiselier via Phabricator