Re: [PATCH] D25036: [CUDA] Disallow exceptions in device code.

2016-09-28 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. jlebar marked an inline comment as done. Closed by commit rL282646: [CUDA] Disallow exceptions in device code. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D25036?vs=72872&id=72918#toc Reposito

Re: [PATCH] D25036: [CUDA] Disallow exceptions in device code.

2016-09-28 Thread Justin Lebar via cfe-commits
jlebar marked an inline comment as done. Comment at: clang/lib/Sema/SemaExprCXX.cpp:688 @@ +687,3 @@ + if (getLangOpts().CUDA) +CheckCUDAExceptionExpr(OpLoc, "throw"); + tra wrote: > Do you need/want to check returned result? We could, and we could return Exp

Re: [PATCH] D25036: [CUDA] Disallow exceptions in device code.

2016-09-28 Thread Artem Belevich via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. One question, LGTM otherwise. Comment at: clang/lib/Sema/SemaExprCXX.cpp:688 @@ +687,3 @@ + if (getLangOpts().CUDA) +CheckCUDAExceptionExpr(OpLoc, "throw"); +