zaks.anna added inline comments.
Comment at: test/Analysis/copypaste/suspicious-clones.cpp:61
@@ -60,3 +60,3 @@
b /= a + b;
- c -= b * a; // expected-warning{{suspicious code clone detected; did you
mean to use 'a'?}}
+ c -= b * a; // expected-warning{{Suspicious code clone
zaks.anna added inline comments.
Comment at: test/Analysis/copypaste/macros.cpp:8
@@ -7,3 +7,3 @@
-int foo(int a) { // expected-warning{{Detected code clone.}}
+int foo(int a) { // expected-warning{{Clones of this code were detected}}
a = a + 1;
- Duplicate c
zaks.anna added inline comments.
Comment at: test/Analysis/copypaste/suspicious-clones.cpp:61
@@ -60,3 +60,3 @@
b /= a + b;
- c -= b * a; // expected-warning{{suspicious code clone detected; did you
mean to use 'a'?}}
+ c -= b * a; // expected-warning{{Suspicious code clone
zaks.anna added inline comments.
Comment at: test/Analysis/copypaste/functions.cpp:7
@@ -6,3 +6,3 @@
-int max(int a, int b) { // expected-warning{{Detected code clone.}}
+int max(int a, int b) { // expected-warning{{Clone of this code was detected}}
log();
"w
v.g.vassilev added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CloneChecker.cpp:102
@@ -95,5 +101,3 @@
// as a note.
-DiagEngine.Report(Group.Sequences.front().getStartLoc(), WarnID);
-for (unsigned i = 1; i < Group.Sequences.size(); ++i) {
- DiagEng
NoQ updated this revision to Diff 72521.
NoQ added a comment.
Addressed inline comments on the original review
https://reviews.llvm.org/D24278. Rebased on top of the updated
https://reviews.llvm.org/D24278. Changed warning messages completely according
to Anna's comments in https://reviews.llvm
