EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM once the `_POSIX_THREADS` comment is addressed.
Comment at: src/config.h:46
@@ +45,3 @@
+defined(__linux__) || \
+defined(__APPLE__) || \
+defined(__CloudABI_
rmaprath added a comment.
@EricWF: Gentle ping.
https://reviews.llvm.org/D24864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath updated this revision to Diff 72653.
rmaprath added a comment.
Herald added subscribers: mgorny, beanz.
Address review comments from @compnerd and @EricWF.
https://reviews.llvm.org/D24864
Files:
CMakeLists.txt
src/config.h
src/cxa_exception.cpp
src/cxa_exception_storage.cpp
s
rmaprath added inline comments.
Comment at: src/config.h:22
@@ +21,3 @@
+
+#if defined(__GNUC__) || defined(__clang__)
+#define _LIBCXXABI_PRAGMA(_parameter_) _Pragma(#_parameter_)
EricWF wrote:
> What's the point of defining `_LIBCXXABI_WARNING`? It's unused and
EricWF added a comment.
LGTM other than the inline comments. I'll give it a final once over tonight or
tomorrow.
Comment at: include/__cxxabi_config.h:36
@@ -35,1 +35,3 @@
#endif
+ #if defined(_MSC_VER) && !defined(__clang__)
+ // Using Microsoft Visual C++ compiler
compnerd added inline comments.
Comment at: src/config.h:41
@@ +40,3 @@
+defined(__CloudABI__) || \
+defined(__sun__)
+# define _LIBCXXABI_HAS_THREAD_API_PTHREAD
Can you change this to `defined(__sun__) && defined(_POSIX_THREADS)` at the
very least? The
rmaprath updated this revision to Diff 72478.
rmaprath added a comment.
Use `__internal_linkage__` attribute to control visibility following
https://reviews.llvm.org/D24642.
https://reviews.llvm.org/D24864
Files:
include/__cxxabi_config.h
src/config.h
src/cxa_exception.cpp
src/cxa_exce
