Re: [PATCH] D24679: [libc++] Fix extern template visibility for Windows

2016-09-19 Thread Shoaib Meenai via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281925: [libc++] Fix extern template visibility for Windows (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D24679?vs=71685&id=71861#toc Repository: rL LLVM https://reviews.

Re: [PATCH] D24679: [libc++] Fix extern template visibility for Windows

2016-09-19 Thread Saleem Abdulrasool via cfe-commits
compnerd accepted this revision. This revision is now accepted and ready to land. Comment at: include/__config:559 @@ -554,1 +558,3 @@ +# define _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS +# define _LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS #endif smeenai wrote: > compnerd w

Re: [PATCH] D24679: [libc++] Fix extern template visibility for Windows

2016-09-19 Thread Shoaib Meenai via cfe-commits
smeenai added inline comments. Comment at: include/__config:559 @@ -554,1 +558,3 @@ +# define _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS +# define _LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS #endif compnerd wrote: > Does it make sense for `_LIBCPP_CLASS_TEMPLATE_INSTANTIATION

Re: [PATCH] D24679: [libc++] Fix extern template visibility for Windows

2016-09-19 Thread Saleem Abdulrasool via cfe-commits
compnerd added inline comments. Comment at: include/__config:559 @@ -554,1 +558,3 @@ +# define _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS +# define _LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS #endif Does it make sense for `_LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS` to ever be