Re: [PATCH] D24669: {Sema] Gcc compatibility of vector shift.

2016-09-26 Thread Vladimir Yakovlev via cfe-commits
vbyakovlcl added inline comments. Comment at: llvm/tools/clang/include/clang/Basic/DiagnosticGroups.td:522 @@ -521,2 +521,3 @@ def GNUZeroVariadicMacroArguments : DiagGroup<"gnu-zero-variadic-macro-arguments">; +def GNUVecElemSize : DiagGroup<"gnu-vec-elem-size">; def Fallback

Re: [PATCH] D24669: {Sema] Gcc compatibility of vector shift.

2016-09-26 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In https://reviews.llvm.org/D24669#548984, @vbyakovlcl wrote: > Clang 3.8 balances vector shift operand erroneous using CheckVectorOperands > which converts one of operand to the type of another. In > https://reviews.llvm.org/D21678 it was fixed by using checkVect

Re: [PATCH] D24669: {Sema] Gcc compatibility of vector shift.

2016-09-21 Thread Vladimir Yakovlev via cfe-commits
vbyakovlcl added a comment. Clang 3.8 balances vector shift operand erroneous using CheckVectorOperands which converts one of operand to the type of another. In https://reviews.llvm.org/D21678 it was fixed by using checkVectorShift instead. As result clang does not emit error if shift operands

Re: [PATCH] D24669: {Sema] Gcc compatibility of vector shift.

2016-09-21 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In clang 3.8, your test code already produces a diagnostic for me: http://coliru.stacked-crooked.com/a/752a4ea34123bdae Repository: rL LLVM https://reviews.llvm.org/D24669 ___ cfe-commits mailing list cfe-commits@l