Re: [PATCH] D24572: [clang-tidy] Clean up code after applying replacements.

2016-10-18 Thread Malcolm Parsons via cfe-commits
On 18 October 2016 at 12:08, Eric Liu wrote: > clang-apply-replacements has some legacy code and needs some refactoring > in order to take advantage of the cleanup feature (because of the new > tooling::Replacements implementation). I had a plan to refactor it but > thought it was a low priority

Re: [PATCH] D24572: [clang-tidy] Clean up code after applying replacements.

2016-10-18 Thread Eric Liu via cfe-commits
clang-apply-replacements has some legacy code and needs some refactoring in order to take advantage of the cleanup feature (because of the new tooling::Replacements implementation). I had a plan to refactor it but thought it was a low priority since most refactoring tools are using replacements app

Re: [PATCH] D24572: [clang-tidy] Clean up code after applying replacements.

2016-09-15 Thread Haojian Wu via cfe-commits
hokein added inline comments. Comment at: clang-tidy/ClangTidy.cpp:206 @@ +205,3 @@ +StringRef Code = Buffer.get()->getBuffer(); +format::FormatStyle Style = format::getLLVMStyle(); +llvm::Expected CleanReplacements = ioeric wrote: > Add a

Re: [PATCH] D24572: [clang-tidy] Clean up code after applying replacements.

2016-09-15 Thread Eric Liu via cfe-commits
ioeric requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/ClangTidy.cpp:25 @@ -24,2 +24,3 @@ #include "clang/ASTMatchers/ASTMatchFinder.h" +#include "clang/Format/Format.h" #include "clang/Frontend/ASTConsumers.h" --