bruno added a comment.
@rnk, do you have any concerns about this patch?
https://reviews.llvm.org/D24472
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:8090
@@ +8089,3 @@
+ *RHSExpr = ImpCastExprToType(RHSExpr->get(), LHSType, CK_BitCast);
+ return VecType;
+}
ahatanak wrote:
> Sorry I wasn't clear, but I was asking whether you were plan
ahatanak added a comment.
Thanks Bruno. I have a couple more questions.
Comment at: lib/Sema/SemaExpr.cpp:8090
@@ +8089,3 @@
+ *RHSExpr = ImpCastExprToType(RHSExpr->get(), LHSType, CK_BitCast);
+ return VecType;
+}
Sorry I wasn't clear, but I was a
bruno updated this revision to Diff 71870.
bruno added a comment.
Update again (now with the right patch) after Akira's comment
https://reviews.llvm.org/D24472
Files:
lib/Sema/SemaExpr.cpp
test/Sema/vector-cast.c
Index: test/Sema/vector-cast.c
==
bruno updated this revision to Diff 71869.
bruno marked an inline comment as done.
bruno added a comment.
Update after Akira's comment
https://reviews.llvm.org/D24472
Files:
lib/Sema/SemaExpr.cpp
test/Sema/vector-cast.c
Index: test/Sema/vector-cast.c
===
bruno marked an inline comment as done.
Comment at: lib/Sema/SemaExpr.cpp:8084
@@ +8083,3 @@
+ *RHSExpr = ImpCastExprToType(RHSExpr->get(), LHSType, CK_BitCast);
+ return LHSType;
+}
ahatanak wrote:
> My understanding is that, when we have a compound
ahatanak added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:8084
@@ +8083,3 @@
+ *RHSExpr = ImpCastExprToType(RHSExpr->get(), LHSType, CK_BitCast);
+ return LHSType;
+}
My understanding is that, when we have a compound assign like "LHS += RHS",
bruno added a comment.
Ping!
https://reviews.llvm.org/D24472
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
