This revision was automatically updated to reflect the committed changes.
Closed by commit rL281540: Add some MS aliases for existing intrinsics
(authored by agutowski).
Changed prior to commit:
https://reviews.llvm.org/D24330?vs=71404&id=71437#toc
Repository:
rL LLVM
https://reviews.llvm.o
agutowski updated this revision to Diff 71404.
agutowski added a comment.
Fix doxygen comment
https://reviews.llvm.org/D24330
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
include/clang/Basic/BuiltinsX86.def
lib/Basic/Targets.cpp
lib/CodeGen/CGBuiltin.cpp
li
agutowski marked an inline comment as done.
agutowski added a comment.
https://reviews.llvm.org/D24330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexshap added a subscriber: alexshap.
Comment at: include/clang/Basic/Builtins.h:142
@@ -141,1 +141,3 @@
+ // \brief Returns true if this builtin requires appropriate header in other
+ // compilers. In Clang it will work even without including it, but we can
emit
---
rnk added a comment.
lgtm We could define a macro that conditionally expands to `extern "C"`, but
then we'd have to undef it, and that seems like no good.
https://reviews.llvm.org/D24330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
agutowski updated this revision to Diff 71271.
agutowski added a comment.
Add extern "C" to Intel intrinsics declarations
https://reviews.llvm.org/D24330
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
include/clang/Basic/BuiltinsX86.def
lib/Basic/Targets.cpp
li
agutowski reopened this revision.
agutowski added a comment.
This revision is now accepted and ready to land.
xmmintrin.h and emmintrin.h broke compilation when included inside extern "C++"
block
Repository:
rL LLVM
https://reviews.llvm.org/D24330
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281375: Add some MS aliases for existing intrinsics
(authored by agutowski).
Changed prior to commit:
https://reviews.llvm.org/D24330?vs=71213&id=71220#toc
Repository:
rL LLVM
https://reviews.llvm.o
agutowski updated this revision to Diff 71213.
agutowski added a comment.
Merge C and C++ tests
https://reviews.llvm.org/D24330
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
include/clang/Basic/BuiltinsX86.def
lib/Basic/Targets.cpp
lib/CodeGen/CGBuiltin.cpp
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm after merging the test back.
Comment at: test/Sema/implicit-intel-builtin-decl.c:4
@@ +3,3 @@
+void f() {
+ (void)_mm_getcsr(); // expected-warning{{implicitly declaring libra
agutowski updated this revision to Diff 71212.
agutowski added a comment.
Add test for implicitly declared intel intrinsic diagnostic in C++
https://reviews.llvm.org/D24330
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
include/clang/Basic/BuiltinsX86.def
lib/Bas
agutowski added inline comments.
Comment at: test/Sema/implicit-intel-builtin-decl.c:4
@@ +3,3 @@
+void f() {
+ (void)_mm_getcsr(); // expected-warning{{implicitly declaring library
function '_mm_getcsr'}} \
+ // expected-note{{include the header or explicitly provide a
decla
rnk added inline comments.
Comment at: test/Sema/implicit-intel-builtin-decl.c:4
@@ +3,3 @@
+void f() {
+ (void)_mm_getcsr(); // expected-warning{{implicitly declaring library
function '_mm_getcsr'}} \
+ // expected-note{{include the header or explicitly provide a
declaration
agutowski updated this revision to Diff 70926.
agutowski added a comment.
Separated Intel intrinsics tests
https://reviews.llvm.org/D24330
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
include/clang/Basic/BuiltinsX86.def
lib/Basic/Targets.cpp
lib/CodeGen/CGBui
agutowski updated this revision to Diff 70923.
agutowski added a comment.
Changed way of handling Intel intrinsics
Removed constant folding
https://reviews.llvm.org/D24330
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
include/clang/Basic/BuiltinsX86.def
lib/Basi
rnk added inline comments.
Comment at: include/clang/Basic/BuiltinsX86.def:304
@@ -303,2 +303,3 @@
TARGET_BUILTIN(__builtin_ia32_ldmxcsr, "vUi", "", "sse")
+TARGET_BUILTIN(_mm_setcsr, "vUi", "", "sse")
TARGET_BUILTIN(__builtin_ia32_stmxcsr, "Ui", "", "sse")
rsmi
rsmith added inline comments.
Comment at: include/clang/Basic/BuiltinsX86.def:304
@@ -303,2 +303,3 @@
TARGET_BUILTIN(__builtin_ia32_ldmxcsr, "vUi", "", "sse")
+TARGET_BUILTIN(_mm_setcsr, "vUi", "", "sse")
TARGET_BUILTIN(__builtin_ia32_stmxcsr, "Ui", "", "sse")
m
majnemer added inline comments.
Comment at: include/clang/Basic/BuiltinsX86.def:304
@@ -303,2 +303,3 @@
TARGET_BUILTIN(__builtin_ia32_ldmxcsr, "vUi", "", "sse")
+TARGET_BUILTIN(_mm_setcsr, "vUi", "", "sse")
TARGET_BUILTIN(__builtin_ia32_stmxcsr, "Ui", "", "sse")
rnk added a comment.
+Richard for ideas on how to navigate the intel intrinsics
Comment at: include/clang/Basic/BuiltinsX86.def:304
@@ -303,2 +303,3 @@
TARGET_BUILTIN(__builtin_ia32_ldmxcsr, "vUi", "", "sse")
+TARGET_BUILTIN(_mm_setcsr, "vUi", "", "sse")
TARGET_BUILTIN(__built
19 matches
Mail list logo
