compnerd added a comment.
Ugh, I was wrong. There is type information associated with a scoped enum.
This means that `_LIBCPP_TYPE_VIS` is the right annotation here.
https://reviews.llvm.org/D24065
___
cfe-commits mailing list
cfe-commits@lists.l
smeenai marked 3 inline comments as done.
smeenai added a comment.
https://reviews.llvm.org/D24065
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai updated this revision to Diff 69797.
smeenai updated the summary for this revision.
smeenai added a comment.
Removing export entirely, per compnerd's suggestion
https://reviews.llvm.org/D24065
Files:
include/__config
Index: include/__config
===
compnerd added inline comments.
Comment at: include/__config:719
@@ -718,3 +718,3 @@
#else // _LIBCPP_HAS_NO_STRONG_ENUMS
-#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS x
+#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS_ONLY x
#define _LI
smeenai added inline comments.
Comment at: include/__config:719
@@ -718,3 +718,3 @@
#else // _LIBCPP_HAS_NO_STRONG_ENUMS
-#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS x
+#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS_ONLY x
#define _LIB
compnerd added inline comments.
Comment at: include/__config:719
@@ -718,3 +718,3 @@
#else // _LIBCPP_HAS_NO_STRONG_ENUMS
-#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS x
+#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS_ONLY x
#define _LI
