Re: [PATCH] D24042: [test] Add libLTO as a clang test dependency on Darwin

2016-08-30 Thread Vedant Kumar via cfe-commits
Done in r280149 (revert this commit) and r280150 (use fake libLTO.dylib). thanks, vedant > On Aug 30, 2016, at 1:12 PM, Mehdi Amini wrote: > > Alternatively, since you only need the presence of a file named libLTO for > the driver to do its magic, test can create an empty file named libLTO.dyl

Re: [PATCH] D24042: [test] Add libLTO as a clang test dependency on Darwin

2016-08-30 Thread Mehdi Amini via cfe-commits
Alternatively, since you only need the presence of a file named libLTO for the driver to do its magic, test can create an empty file named libLTO.dylib and use the -ccc-install-dir to make sure the right flag is passed. > On Aug 30, 2016, at 10:40 AM, Vedant Kumar wrote: > > vsk created this

Re: [PATCH] D24042: [test] Add libLTO as a clang test dependency on Darwin

2016-08-30 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280142: [test] Add libLTO as a clang test dependency on Darwin (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D24042?vs=69723&id=69743#toc Repository: rL LLVM https://revie

Re: [PATCH] D24042: [test] Add libLTO as a clang test dependency on Darwin

2016-08-30 Thread Bruno Cardoso Lopes via cfe-commits
bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Nice, LGTM https://reviews.llvm.org/D24042 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c