Re: [PATCH] D23791: [libc++] Perform configuration checks with -nodefaultlibs

2016-08-23 Thread Saleem Abdulrasool via cfe-commits
compnerd closed this revision. compnerd added a comment. SVN r279584. https://reviews.llvm.org/D23791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23791: [libc++] Perform configuration checks with -nodefaultlibs

2016-08-23 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I think this makes sense. https://reviews.llvm.org/D23791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

Re: [PATCH] D23791: [libc++] Perform configuration checks with -nodefaultlibs

2016-08-23 Thread Shoaib Meenai via cfe-commits
via cfe-commits Reply-To: Shoaib Meenai Date: Tuesday, August 23, 2016 at 10:18 AM To: "reviews+d23791+public+1be7b6c753063...@reviews.llvm.org" , Eric Fiselier Cc: "mclow.li...@gmail.com" , Richard Smith , "cfe-commits@lists.llvm.org" Subject: Re: [P

Re: [PATCH] D23791: [libc++] Perform configuration checks with -nodefaultlibs

2016-08-23 Thread Shoaib Meenai via cfe-commits
I tested on OS X 10.11 and Ubuntu 16.04. Get Outlook for iOS On Mon, Aug 22, 2016 at 8:37 PM -0700, "Eric Fiselier" mailto:e...@efcs.ca>> wrote: What platforms was this tested on? On Aug 22, 2016 9:20 PM, "Shoaib Meenai" mailto:smee...@fb.com>> wrote: smeenai create

Re: [PATCH] D23791: [libc++] Perform configuration checks with -nodefaultlibs

2016-08-22 Thread Eric Fiselier via cfe-commits
What platforms was this tested on? On Aug 22, 2016 9:20 PM, "Shoaib Meenai" wrote: > smeenai created this revision. > smeenai added reviewers: beanz, compnerd, EricWF, mclow.lists, rsmith. > smeenai added a subscriber: cfe-commits. > > We're compiling libc++ with -nodefaultlibs, so we should als