nlewycky updated this revision to Diff 69905.
https://reviews.llvm.org/D23734
Files:
lib/Transforms/Instrumentation/GCOVProfiling.cpp
test/Transforms/GCOVProfiling/three-element-mdnode.ll
tools/clang/include/clang/Driver/CC1Options.td
tools/clang/include/clang/Driver/Options.td
tools/cl
compnerd added inline comments.
Comment at: lib/Transforms/Instrumentation/GCOVProfiling.cpp:447
@@ -432,3 +446,3 @@
return Filename.str();
}
}
A quick pass over this yielded something like:
if (N->getNumOperands() != 2 && N->getNumOperan
nlewycky added inline comments.
Comment at: lib/Transforms/Instrumentation/GCOVProfiling.cpp:447
@@ -432,3 +446,3 @@
return Filename.str();
}
}
compnerd wrote:
> It really feels like these two cases can be collapsed.
I don't see a great way to
nlewycky updated this revision to Diff 69778.
nlewycky marked 5 inline comments as done.
https://reviews.llvm.org/D23734
Files:
lib/Transforms/Instrumentation/GCOVProfiling.cpp
test/Transforms/GCOVProfiling/three-element-mdnode.ll
tools/clang/include/clang/Driver/CC1Options.td
tools/clang
compnerd added a subscriber: compnerd.
Comment at: lib/Transforms/Instrumentation/GCOVProfiling.cpp:121
@@ -120,2 +120,3 @@
- std::string mangleName(const DICompileUnit *CU, const char *NewStem);
+ enum GCovFileType { GCNO, GCDA };
+ std::string mangleName(const DICompileUnit
nlewycky added a comment.
Ping!
I think the review this patch really needs is a comparison to GCC's
implementation to double-check that it really does the same thing that GCC
does. Is there a gcov user who could take a look at this?
https://reviews.llvm.org/D23734
_
nlewycky updated this revision to Diff 68755.
nlewycky added a comment.
Forgot clang changes!
https://reviews.llvm.org/D23734
Files:
lib/Transforms/Instrumentation/GCOVProfiling.cpp
test/Transforms/GCOVProfiling/three-element-mdnode.ll
tools/clang/include/clang/Driver/CC1Options.td
tool
