Re: [PATCH] D23239: [CUDA] Add __device__ overloads for placement new and delete.

2016-08-09 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL278194: [CUDA] Add __device__ overloads for placement new and delete. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D23239?vs=67282&id=67447#toc Repository: rL LLVM https:/

Re: [PATCH] D23239: [CUDA] Add __device__ overloads for placement new and delete.

2016-08-09 Thread Artem Belevich via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D23239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

Re: [PATCH] D23239: [CUDA] Add __device__ overloads for placement new and delete.

2016-08-08 Thread Justin Lebar via cfe-commits
jlebar added a comment. In https://reviews.llvm.org/D23239#508863, @tra wrote: > I think we need to add `noexcept` for these in c++11. Argh, you are completely right. Thank you for the review. https://reviews.llvm.org/D23239 ___ cfe-commits mail

Re: [PATCH] D23239: [CUDA] Add __device__ overloads for placement new and delete.

2016-08-08 Thread Justin Lebar via cfe-commits
jlebar updated this revision to Diff 67282. jlebar added a comment. Add noexcept. https://reviews.llvm.org/D23239 Files: clang/lib/Headers/__clang_cuda_runtime_wrapper.h Index: clang/lib/Headers/__clang_cuda_runtime_wrapper.h ==

Re: [PATCH] D23239: [CUDA] Add __device__ overloads for placement new and delete.

2016-08-08 Thread Artem Belevich via cfe-commits
tra added a comment. I think we need to add `noexcept` for these in c++11. https://reviews.llvm.org/D23239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits